fix: repair failing utility tests across 5 modules#198
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide throws on division by zero instead of returning Infinity - string-utils: wordCount collapses consecutive whitespace; implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: fix off-by-one in formatRelative day rounding - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests in the utility library. The full suite now passes: 60 pass, 0 fail. No tests were modified and no dependencies were added.
Fixes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0instead of returningInfinity.src/string-utils.ts—wordCountsplits on/\s+/to collapse consecutive whitespace;truncateimplemented (returns unchanged within limit, truncates at word boundary, ellipsis counts towardmaxLength, handles strings shorter than the ellipsis).src/task-manager.ts— implementedremove(returnsfalsefor unknown id),update(title/priority, returnsfalsefor unknown id), andsortBy(priority high→medium→low; createdAt oldest first).src/date-utils.ts— fixed off-by-one informatRelative: day count now rounds correctly so exactly 36 hours reads "2 days ago".src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with a port (e.g.http://localhost:3000).Verification
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions / notes
date-utils.formatRelative: the fix usesMath.roundon the day count. This satisfies the test and shifts the hours→days display boundary. No test covers the 12-23h range; left minimal per the "fix only what the tests require" constraint.string-utils.truncate: whenmaxLength <= ellipsis length, a raw slice (no ellipsis) is returned. This path is untested; chosen as a reasonable fallback without expanding scope.🤖 Generated with QuantCode Agent